search

neuropsychology / NeuroKit.py

A Python Toolbox for Statistics and Neurophysiological Signal Processing (EEG, EDA, ECG, EMG...).
http://neurokit.rtfd.io
MIT License
365 stars 102 forks source link

Allow ecg_hrv to take either RPeaks or RRis as argument #54

Closed lamourj closed 6 years ago

lamourj commented 6 years ago

Sorry for the delay, this was actually ready for a long time but I just discovered I only had the change locally. It simply offers the option to pass either RPeaks or RRIs to the ecg_hrv function, instead of imposing to pass the rpeaks.

codecov[bot] commented 6 years ago

Codecov Report

Merging #54 into master will decrease coverage by 0.01%. The diff coverage is 54.54%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #54      +/-   ##
==========================================
- Coverage   53.29%   53.28%   -0.02%     
==========================================
  Files          32       32              
  Lines        1910     1916       +6     
==========================================
+ Hits         1018     1021       +3     
- Misses        892      895       +3
Impacted Files Coverage Δ
neurokit/signal/complexity.py 53.47% <ø> (ø) :arrow_up:
neurokit/bio/bio_ecg.py 66.25% <54.54%> (-0.31%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0199730...4f940f4. Read the comment docs.

DominiqueMakowski commented 6 years ago

Awesome, thanks for that PR :)