search

neuropsychology / NeuroKit.py

A Python Toolbox for Statistics and Neurophysiological Signal Processing (EEG, EDA, ECG, EMG...).
http://neurokit.rtfd.io
MIT License
365 stars 102 forks source link

python2 compatibility: make bio_eda compatible #83

Closed ucohen closed 5 years ago

ucohen commented 5 years ago

make division support float values

codecov[bot] commented 5 years ago

Codecov Report

Merging #83 into master will increase coverage by 0.06%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #83      +/-   ##
==========================================
+ Coverage   34.44%   34.51%   +0.06%     
==========================================
  Files          31       31              
  Lines        2006     2008       +2     
==========================================
+ Hits          691      693       +2     
  Misses       1315     1315
Impacted Files Coverage Δ
neurokit/statistics/statistics.py 88.23% <100%> (ø) :arrow_up:
neurokit/statistics/routines.py 72.82% <100%> (+0.14%) :arrow_up:
neurokit/bio/bio_eda.py 6.62% <100%> (+0.51%) :arrow_up:
neurokit/bio/bio_ecg_preprocessing.py 64.51% <0%> (-1.3%) :arrow_down:
neurokit/bio/bio_ecg.py 34.53% <0%> (+0.6%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0ce8fc0...0196fc7. Read the comment docs.

ucohen commented 5 years ago

@DominiqueMakowski need your assistance with the review. thanks.

DominiqueMakowski commented 5 years ago

@ucohen I forgot, but could you add yourself (if you want oc) to the contributors here? 😉