neuropsychology / NeuroKit.py

A Python Toolbox for Statistics and Neurophysiological Signal Processing (EEG, EDA, ECG, EMG...).
http://neurokit.rtfd.io
MIT License
365 stars 102 forks source link

eda_process: band, order, and frequency are hardcoded #98

Open jdkent opened 5 years ago

jdkent commented 5 years ago

Thanks for making this awesome tool, I've recently found this and this will certainly make my life easier.

I have a request from my PI to do bandpass filtering, but with the current options this is unavailable. I had a question about why band, order, and frequency were hard coded. I can submit a pull request implementing this functionality if you are in support of adding this, or if you could provide a reason as to why this may be a bad idea (the hard coded numbers are necessary to be at those values) and I will try to communicate that to my PI.