neuropsychology / NeuroKit

NeuroKit2: The Python Toolbox for Neurophysiological Signal Processing
https://neuropsychology.github.io/NeuroKit
MIT License
1.52k stars 407 forks source link

ecg_delineate #1032

Open francu-pixel opened 2 days ago

francu-pixel commented 2 days ago

Goodmorning, I'm using neurokit2 for the analysis of cardiomyocytes acquisitions and it's working very well with the ECG package. I only have one doubt: I feel like ecg_delineate actually makes up the P and T detection sometimes, since these points are identified by ecg_delineate but they are not really present in the signal. Is it a way to make a better detection of P and T peaks and allow the code to deal with the case where they are not present?

welcome[bot] commented 2 days ago

Hi 👋 Thanks for reaching out and opening your first issue here! We'll try to come back to you as soon as possible. ❤️ kenobi

DominiqueMakowski commented 20 hours ago

The current algorithms are kind of looking for the "best fitting" location of these waves,but there's no fallback in case the predicted location is bad. So unfortuntaly no, the current alrogithms are not "smart" enough to know whether the waves are present or not. Maybe there are better delineations algos out there that we could add

francu-pixel commented 17 hours ago

Ok, thank you so much for your answer. I have another question: when trying to delineate the T peak, what is the actual logic behind the function? Mainly I would like to understand if into a biphasic T wave it will detect the first or the second T peak usually. Thank you in advance.