neuropsychology / NeuroKit

NeuroKit2: The Python Toolbox for Neurophysiological Signal Processing
https://neuropsychology.github.io/NeuroKit
MIT License
1.55k stars 415 forks source link

Inconsistent signal_interpolate methods in ppg_quality() #1043

Open athatcher13 opened 3 hours ago

athatcher13 commented 3 hours ago

Describe the bug ppg_quality with method=

Expected behaviour I would expect this behavior to be consistent between ppg_quality methods. method='previous' seems most apt as the quality is truly calcuated beat-by-beat - it will hold the most recent beat's quality value until a new value comes along to replace it. method='quadratic' frequently fills the vector with values above and below the specified 'templatematch' range of [0, 1].

System Specifications

welcome[bot] commented 3 hours ago

Hi 👋 Thanks for reaching out and opening your first issue here! We'll try to come back to you as soon as possible. ❤️ kenobi