neuropsychology / NeuroKit

NeuroKit2: The Python Toolbox for Neurophysiological Signal Processing

https://neuropsychology.github.io/NeuroKit

MIT License

1.53k stars 410 forks source link

Update ecg_segment.py #922

Closed hyunlimy closed 11 months ago

hyunlimy commented 11 months ago

modify plotting error

Description

I think there was an error referencing the y value incorrectly when drawing the segment_plot. Since the previously declared mean_heartbeat is a grouped DataFrame, you need to explicitly specify the columns to get the values correctly.

Proposed Changes

I changed the _ecg_segment_plot() function so that it can properly referencing the y value.

welcome[bot] commented 11 months ago

Thanks for opening this pull request! We'll make sure it's perfect before merging 🤗 force Make sure to read the contributing guide. Also, if you think that your contribution is worthy of it, you can consider adding yourself to the Contributors list (feel free to ask us if you have any doubts).

codeclimate[bot] commented 11 months ago

Code Climate has analyzed commit 4d4bd7af and detected 0 issues on this pull request.

View more on Code Climate.

DominiqueMakowski commented 11 months ago

Hi @hyunlimy, may I ask why did you close this?