Missing runtime dependency "requests" in 0.2.7

[hoechenberger]

Hello! I'm co-maintaining the neurokit2 package on coda-forge. When trying to test version 0.2.7 (a simple import test), it appeared that a new runtime dependency on requests has been introduced, but it's not explicitly specified in the project dependencies. The requests dependency often goes unnoticed as most Python installations deploy requests by default. Could you please explicitly add this package to the list of dependences? Thanks!

[DominiqueMakowski]

Hi @hoechenberger thanks for mentioning that. Is it enough if I add requests to the test requirements?

[hoechenberger]

Hello @DominiqueMakowski, thanks for the swift response! No, even import neurokit2 fails without requests installed, so it should most probably go into the list of requirements.

Thank you!

[aidin36]

I ran into this issue too. I hope you release a fix soon! Thanks for the time you're putting into this package!

The steps to reproduce:

mkdir testproject
cd testproject
pipenv install neurokit2
pipenv run python -c "import neurokit2"

ModuleNotFoundError: No module named 'requests'

[DominiqueMakowski]

This should be fixed on the dev version:

pip install https://github.com/neuropsychology/neurokit/zipball/dev --upgrade

[stale[bot]]

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.