Open taulokoka opened 9 months ago
Hi 👋 Thanks for reaching out and opening your first issue here! We'll try to come back to you as soon as possible. ❤️
Hi @JonasEmrich, there is a request for adding VG-based peak detection methods to NeuroKit, and I was wondering what your thoughts on this are ☺️ Options include:
vg-beat-detectors
, but since we operate on a minimum dependency, it would be a soft dependency, i.e., asking users to manually install the package the first time.
ts2vg
I'd say that option 4 is one of the best in terms of pros/cons balance, but let us know what you think!
Hi @DominiqueMakowski, thanks for reaching out! I also think option 4 would be the optimal choice. Since I am fairly new to the process, maybe you could guide a bit me through the next steps 😃
Of course :)
The rough steps would be:
dev
branchecg_peaks_vgmethod
_ecg_findpeaks_visibilitygraph()
(I'd say let's focus on the FastWHVG method as you seem to think it's superior?)ecg_findpeaks()
function Don't hesitate to add links to your package, for instance in the core code, like # Original function developed by ... and available in ...
etc.
Don't hesitate to ask if there's anything
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Dear NeuroKit,
the visibility graph method you have included in your package (koka2022) has been recently updated (https://ieeexplore.ieee.org/document/10290007) and is being maintained at https://github.com/JonasEmrich/vg-beat-detectors. It would be appreciated, if you could update the method since the recent version is orders of magnitude faster than the previous, while providing better results.
Best regards, Taulant Koka