Open jchromik opened 11 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
87c8c60
) 54.82% compared to head (59d0c83
) 54.88%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@DominiqueMakowski
I renamed the parameter tolerance
to duration_min
. All checks pass now. Code cov is complete for all my changes.
(I'm still open for feedback and critique, though ;-) )
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Description
This PR aims at adding the function
signal_flatintervals
. The function can identify flatline intervals in signals and if modelled aftersignal_flatline
. We discussed this feature in #823. It is one step towards making NeuroKit able to process long-term ECGs with bad or unprocessable intervals.Possible Next Step
A possible next step could be to a
bad_intervals
keyword argument to the peak detection functions to that the peak detector does not need to process the whole signal but only the good (non-flatline parts).Limitations / Concerns
signal_flatintervals
needs two "magic" parameters threshold and tolerance.threshold
is the same as in signal_flatline with a default values of 0.01 (1% percent of the largest spike in the signal).tolerance
says how long the flatline interval needs to be to be recognised as such default is 60 seconds.ecg_simulate
and is therefore quite slow (approx. 10s). I am open to suggestions on how to speed this up.Checklist