search

neuropsychology / NeuroKit

NeuroKit2: The Python Toolbox for Neurophysiological Signal Processing
https://neuropsychology.github.io/NeuroKit
MIT License
1.58k stars 421 forks source link

Remove tests from pyproject #941

Closed Ninebell closed 10 months ago

Ninebell commented 10 months ago

when install neurokit2 by pip, tests folder in neurokit repository are installed in python env. they can conflict with other local tests directory.

This PR removed tests folder from setup.py by editing MANIFEST.in

welcome[bot] commented 10 months ago

Thanks for opening this pull request! We'll make sure it's perfect before merging 🤗 force Make sure to read the contributing guide. Also, if you think that your contribution is worthy of it, you can consider adding yourself to the Contributors list (feel free to ask us if you have any doubts).

codecov-commenter commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (3d004b4) 54.86% compared to head (2c410f4) 54.61%. Report is 17 commits behind head on dev.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #941 +/- ## ========================================== - Coverage 54.86% 54.61% -0.25% ========================================== Files 303 304 +1 Lines 14255 14333 +78 ========================================== + Hits 7821 7828 +7 - Misses 6434 6505 +71 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

DominiqueMakowski commented 10 months ago

thanks!

welcome[bot] commented 10 months ago

landing Congrats on merging your first pull request! 🎉🍾 We're looking forward to your next one!