[Fix] refactor ecg_findpeaks

[danibene]

Description

This PR aims to refactor ecg_findpeaks() following a failing codeclimate check: https://codeclimate.com/github/neuropsychology/NeuroKit/pull/926

Avoid deeply nested control flow statements.

                    for missed_peak in missed_peaks:
                        if missed_peak - peaks[idx[-2]] > int(0.36 * sampling_rate) and ma[missed_peak] > 0.5 * th:
                            insort(QRS, missed_peak)
                            break

Severity: Major Found in neurokit2/ecg/ecg_findpeaks.py - About 45 mins to fix

Proposed Changes

I changed the ecg_findpeaks_hamilton() function so that it is broken up into smaller functions. I also added a regression test for it.

Checklist

Here are some things to check before creating the PR. If you encounter any issues, do let us know :)

• [x] I have read the CONTRIBUTING file.
• [x] My PR is targeted at the dev branch (and not towards the master branch).
• [ ] I ran the CODE CHECKS on the files I added or modified and fixed the errors.
• [ ] I have added the newly added features to News.rst (if applicable)

[DominiqueMakowski]

Nice, though if need be we can also just discard that check on codeclimate - I wonder whether you have access to codeclimate's NK checks if you log in with ur GH account

[danibene]

Couldn't find that option - would it make sense to update the config file in the repository?

[DominiqueMakowski]

Couldn't find that option - would it make sense to update the config file in the repository?

Yeah to be fair I think we should drop codeclimate entirely... it was kinda useful years ago but now with all the GH actions not so much

[DominiqueMakowski]

can I merge this?