neuropsychology / NeuroKit

NeuroKit2: The Python Toolbox for Neurophysiological Signal Processing
https://neuropsychology.github.io/NeuroKit
MIT License
1.58k stars 421 forks source link

ReleasePR workflow failing for v0.2.8 #984

Closed EvanCesanek closed 6 months ago

EvanCesanek commented 7 months ago

Perhaps you are already aware of this, but the latest release v0.2.8 is not deploying to PyPI, so it cannot be installed using pip install.

See Actions -> Workflows -> ReleasePR -> Merge pull request #926 from neuropsychology/dev -> Build and publish Python 🐍 distributions 📦 to PyPI and TestPyPI

Apologies for not resolving this myself, but I am not really set up to test this workflow.

[Edited: I originally misunderstood the source of the problem and suggested a fix that wouldn't resolve it. See my next comment for the actual problem and a proposed solution.]

Thank you!

welcome[bot] commented 7 months ago

Hi 👋 Thanks for reaching out and opening your first issue here! We'll try to come back to you as soon as possible. ❤️ kenobi

DerAndereJohannes commented 6 months ago

It would be great to get this fixed, i'm guessing that only a maintainer can realistically make and test these changes, right?

EvanCesanek commented 6 months ago

Thanks @DerAndereJohannes! I agree. I also looked back at this quickly and realized my thoughts above about the source of this failure were incorrect. Examining the ReleasePR workflow logs from the two Attempts reveals the actual issue:

Attempt 1 successfully deployed to Test PyPI: https://test.pypi.org/project/neurokit2/0.2.8/ However, the next step failed, when deploying to regular PyPI with the following error:

ERROR    HTTPError: 400 Bad Request from https://upload.pypi.org/legacy/        
         User 'DominiqueMakowski' does not have a verified primary email        
         address. Please add a verified primary email before attempting to      
         upload to PyPI. See https://pypi.org/help/#verified-email for more     
         information.

Unfortunately, even if the verified primary email problem is fixed, we will get a new error on retrying the ReleasePR workflow (see Attempt 2). This is due to the fact that 0.2.8 was successfully deployed to TestPyPI in Attempt 1.

ERROR    HTTPError: 400 Bad Request from https://test.pypi.org/legacy/          
         File already exists. See https://test.pypi.org/help/#file-name-reuse   
         for more information.

So it looks like two things must be done: (1) the verified primary email problem must be corrected and then (2) a modified version of the ReleasePR workflow must be run that skips the "Publish distribution to TestPyPI" step.

DominiqueMakowski commented 6 months ago

Should be fixed now