neuropycon / graphpype

Neuropycon package of functions for electrophysiology analysis, can be used from ephypype and nipype

https://neuropycon.github.io/graphpype/

BSD 3-Clause "New" or "Revised" License

21 stars 11 forks source link

Add api #44

Closed annapasca closed 5 years ago

annapasca commented 5 years ago

Added list of functions in https://neuropycon.github.io/graphpype/api.html

annapasca commented 5 years ago

@davidmeunier79 do you have idea why travis crashes? I added some doc for API

davidmeunier79 commented 5 years ago

It seems it is coming from a change of version of py.test:

platform linux -- Python 3.6.9, pytest-5.2.1, py-1.8.0, pluggy-0.13.0 rootdir: /home/travis/build/neuropycon/graphpype plugins: cov-2.8.1 collecting ...

And on the previous version that passed the test: platform linux -- Python 3.6.9, pytest-5.2.0, py-1.8.0, pluggy-0.13.0 rootdir: /home/travis/build/neuropycon/graphpype plugins: cov-2.7.1 collected 65 items

Does that makes any sense to anyone? I will try to see if the version that passed (https://github.com/neuropycon/graphpype/pull/43) is now failing

davidmeunier79 commented 5 years ago

Yes it is indeed because of that, see https://github.com/neuropycon/graphpype/pull/46. I am running now a test with forcing version pytest-cov==2.7.1 (the previous version that was working earlier)

davidmeunier79 commented 5 years ago

Now it is working for the test with Python 3.6, but still fails with python 2.7.

Logs =

platform linux2 -- Python 2.7.16, pytest-4.6.6, py-1.8.0, pluggy-0.13.0

rootdir: /home/travis/build/neuropycon/graphpype

plugins: cov-2.7.1

collecting ...

Previous logs =

platform linux2 -- Python 2.7.16, pytest-4.6.5, py-1.8.0, pluggy-0.13.0

rootdir: /home/travis/build/neuropycon/graphpype

plugins: cov-2.7.1

collected 65 items

davidmeunier79 commented 5 years ago

This is unpredictable: https://travis-ci.org/neuropycon/graphpype/builds/599150569?utm_source=github_status&utm_medium=notification and https://travis-ci.org/neuropycon/graphpype/builds/599164334?utm_source=github_status&utm_medium=notification were the same, but it is not the same build (once python3.6, once python2.7) that crashed!

davidmeunier79 commented 5 years ago

Could it be related to this issue? http://doc.pytest.org/en/latest/py27-py34-deprecation.html

codecov[bot] commented 5 years ago

Codecov Report

Merging #44 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #44   +/-   ##
=======================================
  Coverage   69.65%   69.65%           
=======================================
  Files          35       35           
  Lines        3065     3065           
=======================================
  Hits         2135     2135           
  Misses        930      930

Impacted Files	Coverage Δ
graphpype/pipelines/conmat_to_graph.py	`6.55% <ø> (ø)`	:arrow_up:
graphpype/pipelines/intmat_to_graph.py	`21.73% <ø> (ø)`	:arrow_up:
graphpype/pipelines/nii_to_conmat.py	`30.24% <ø> (ø)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 89594b0...43f0094. Read the comment docs.

annapasca commented 5 years ago

@davidmeunier79 if for you is ok could you merge?

davidmeunier79 commented 5 years ago

@annapasca How did you get it to pass??? I am still strugling with my own PR https://github.com/neuropycon/graphpype/pull/45

annapasca commented 5 years ago

@davidmeunier79 I didn't do anything o.O I only run again the process in CircleCi