neurorestore / Augur

Cell type prioritization in single-cell data
MIT License
94 stars 10 forks source link

Fix wrong sc object used and deprecation warning in plot_umap #13

Closed ycl6 closed 2 years ago

ycl6 commented 2 years ago

The PR fixed a minor bug in the plot_umap function where the sc object is wrongly named when monocle3 or SingleCellExperiment class object is used. It also change the guides argument from fill = FALSE to fill = "none" to avoid the deprecation warning.

Warning: `guides(<scale> = FALSE)` is deprecated. Please use `guides(<scale> =
"none")` instead.

Edit: re 551f9e0, it adds the missing row names to red_coord if sc is a SingleCellExperiment object, so that the barcode column can be correctly created when calling the rownames_to_column function in:

https://github.com/neurorestore/Augur/blob/3b51e4ed004ef6351f6930c1d1b44eed48246f1e/R/plot_umap.R#L128-L134