neurorestore / DE-analysis

35 stars 10 forks source link

AUCC code: how do you break ties with wilcox data #11

Closed kalanir closed 3 months ago

kalanir commented 4 months ago

Looking at the "functions/calculate_overlap.R" code, it seems that a 'test_statistic' column is not assigned within the wilcox output and I don't see any such column in the FindMarkers wilcox dataframes. How did you break ties in the AUCC analysis when comparing wilcox results because I've noticed some of the genes can have the same pvalue assigned (0s and 1s)?

skinnider commented 3 months ago

This is addressed in the Methods

We observed that some statistical tests returned a large number of p-values below the double precision limit in R (approximately 2 × 10–308), potentially confounding the calculation of the concordance metrics described below. To avoid this pitfall, we modified the Seurat implementation to also return the value of the test statistic from which the p-value was derived. The modified version of Seurat 3.1.5 used to perform all single-cell DE analyses reported in this study is available from http://github.com/jordansquair/Seurat.