[REF] refactor meta_stuff to use NiMARE

neuroscout / neuroscout-paper

Neuroscout paper analysis repository

https://neuroscout.github.io/neuroscout-paper/

Other

0 stars 0 forks source link

[REF] refactor meta_stuff to use NiMARE #27

Closed jdkent closed 3 years ago

jdkent commented 3 years ago

Trying to use NiMARE instead of clever code.

blocking:
- neurostuff/NiMARE#432
- neurostuff/NiMARE#439

jdkent commented 3 years ago

@tyarkoni I have a notebook updated with the nimare method and your method, they are now equivalent (I made a mistake with the convert_neurovault_to_dataset function (filename collisions), but fixed it with neurostuff/NiMARE#457)

rbroc commented 3 years ago

note to future selves: analysis ids could be imported more compactly from json files in the models folder using load_collection from tools.base

tyarkoni commented 3 years ago

Okay to merge this, @jdkent?

jdkent commented 3 years ago

yes, should be good to merge now