search

neurosity / openbci-dashboard

A fullstack javascript app for capturing and visualizing OpenBCI EEG data
93 stars 23 forks source link

Closes #17: add gamma to the frequency plot #18

Closed alexcastillo closed 8 years ago

alexcastillo commented 8 years ago

@andrewheusser @teonbrooks can you please review?

teonbrooks commented 8 years ago

we are currently filtering the signal before we do the fft, since there is a lowpass filter, there will not be in power in the gamma frequency band. that would mean, we should do filtering separate from the fft if we want to see particular bands. cc: @andrewheusser

teonbrooks commented 8 years ago

but the code is correct

andrewheusser commented 8 years ago

good call @teonbrooks. I think ultimately we will want the filtering to have some default (like a high pass at 1 and a notch, but flexible such that the user can change in in the GUI like the Processing GUI is set up

andrewheusser commented 8 years ago

also, am I missing something here? When I browse the files, all I see are the frequency, time-series and topo folders....

andrewheusser commented 8 years ago

https://github.com/NeuroJS/openbci-dashboard/tree/6f9a5a260c8904e48756da6125963fbaf0438513/app/components

alexcastillo commented 8 years ago

@andrewheusser I abstracted the frequency bands into a single directive, see index.html for usage.

alexcastillo commented 8 years ago

Oops @andrewheusser! Forgot to do a git add. It's fixed now.

andrewheusser commented 8 years ago

I commented in the code but ill reiterate, I think we should remove the timeseries filter code from this PR, merge the branch, and then implement the timeseries filtering once we've had a chance to discuss and make a plan :)

andrewheusser commented 8 years ago

otherwise looks good to me!