[MRG] Restored default value for write_bounding_box

neurospin / pypreprocess

Preprocessing scripts for neuro imaging

105 stars 66 forks source link

[MRG] Restored default value for write_bounding_box #320

Closed Hororohoruru closed 5 years ago

Hororohoruru commented 5 years ago

Restored the previous value for the write_bounding_box parameter, as mentioned in #312

Since it seems to be a fixed value, I could also add a keyword argument to do_subject_normalize and put this default value there, so is easily accesible in case it needs change.

thomasbazeille commented 5 years ago

CircleCI fails as usual, because of SPM installation problem unrelated to the PR.

TravisCI for another unrelated reason linked to #210 and coming from a bad test design that creates non-deterministic test failure. When a maintainer is reviewing this, please rebuild TravisCI job and it should work.

bthirion commented 5 years ago

@AGrigis any opinion ?

AGrigis commented 5 years ago

I added this parameter for the IMAGEN processings in order to work with a non-MNI template. As it is not the usual way to preprocess data, I think you can restaure the former hardcoded value.

bthirion commented 5 years ago

OK, merging. Thx.