PEP8 Compliance and several fixes

neurospin / unicog

9 stars 7 forks source link

PEP8 Compliance and several fixes #14

Closed clementpoiret closed 3 years ago

clementpoiret commented 3 years ago

Hi,

I propose several changes to improve neurospin_to_bids.py which is causing some issues:

Several fixes for PEP8 compliance, which - I hope - should improve readability and facilitate subsequent maintenance,
fixed readme_input being assigned but never used. Whatever the user inputs, it wasn't written into the readme file.

clementpoiret commented 3 years ago

[‘a’, ‘b’, ‘c’] in examples are incorrect and lead to a wrongly formatted *.json file. Therefore, I update the input prompts to help new users. The input ['a', 'b', 'c'] is incorrect and should be a, b, c for correct parsing

clementpoiret commented 3 years ago

acq_label wasn't taken into consideration because left unassigned. Fixed in 8b3433f dwi wasn't supported in the loop. Fixed in cbeae5e

isadenghien commented 3 years ago

Thanks Clément for those improvements. I ran a small test on my workstation, it's ok for me. I suppose the bids script now requires a specific repository. I'm going to check with the others involved.

clementpoiret commented 3 years ago

No problem :) Yes I agree with you, I think it could be a good idea to have a specific repository for neurospin_to_bids

Have a nice day, Clément