search

neurospin / unicog

9 stars 7 forks source link

Bids for pr #6

Closed isadenghien closed 7 years ago

isadenghien commented 7 years ago

fix many wrong paths

MartinPerez commented 7 years ago

@isadenghien thanks for the doc development. In my comments I explain how to consider the case of sessions. Also responding to the opened issue #5. +1 for the code changes.

MartinPerez commented 7 years ago

I checked the changes and added some extra comments. One thing that I think is important is to keep the same notation across the different examples and to keep that notation aligned with BIDS. To help people get into it.

Also I realize we have the option now, before we advertise this to maybe use participant_label and session_label instead of participant_id and session_id, if we want to avoid writing in each slot the whole (sub-label) and (ses-label) and just be able to write the labels. I dont have a strong position about this, what do you think is better for people using this?

MartinPerez commented 7 years ago

@isadenghien I need to work on this code, there are still some small inconsistencies in the doc with respect to the BIDS standard, but I will merge and correct them in a new PR. Thanks for improving the documentation :).