Change the name Dataset to Studyset

neurostuff / NiMARE

Coordinate- and image-based meta-analysis in Python

https://nimare.readthedocs.io

MIT License

184 stars 58 forks source link

Change the name Dataset to Studyset #622

Open jdkent opened 2 years ago

jdkent commented 2 years ago

Summary

All references to Dataset to be changed to Studyset

Additional details

The term dataset is an overloaded term that references a lot of valid structures (e.g., raw neuroimaging data BIDs dataset, preprocessed data fMRIPREP dataset) whereas studyset more specifically targeting a set of studies.

Next steps

We are discussing going this route for neurostore/neurosynth, and it would be good to be consistent between terms for neurostore/neurosynth/nimare.

WDYT @tsalo?

tsalo commented 2 years ago

I think it's a reasonable step forward. I'd also move the class from nimare.dataset to nimare.base if we're going to be changing things around.

EDIT: Or maybe it should go in nimare.nimads, given #218...

Is "Studyset" the terminology used in NIMADS as well? Or, more generally, is the proposed change compatible with #218?

tsalo commented 2 years ago

I'd also like to try to tackle all of the NIMADS stuff in one release, so that there's one big API change instead of API changes spread across 2-3 releases. It would be important to me to make this change within ~1-2 months of the changes for #218.