search

neurostuff / NiMARE

Coordinate- and image-based meta-analysis in Python
https://nimare.readthedocs.io
MIT License
182 stars 58 forks source link

nilearn 0.10.3 breaks nimare #872

Closed adelavega closed 7 months ago

adelavega commented 9 months ago 
     9 import pymare
     10 from joblib import Memory
---> 11 from nilearn._utils.niimg_conversions import _check_same_fov
     12 from nilearn.image import concat_imgs, resample_to_img
     13 from nilearn.input_data import NiftiMasker

ImportError: cannot import name '_check_same_fov' from 'nilearn._utils.niimg_conversions' (/usr/local/lib/python3.10/dist-packages/nilearn/_utils/niimg_conversions.py)
Remi-Gau commented 9 months ago

yeah we did 'some' clean up of how some internal functions were named:

adelavega commented 9 months ago

yep! got that taken care of in #873

our fault for relying on private functions

Remi-Gau commented 9 months ago

our fault for relying on private functions

Well I would be throwing stones in a glass house if I said I have never used private functions from another library. 😜

Remi-Gau commented 9 months ago

The bug for the color bar issue should be fixed now.

FYI we have a few more bugs to fix before we can cut a bug fix release: https://github.com/nilearn/nilearn/milestone/27

Not sure how easily you can test Nimare using Nilearn from main, to see that things are now good on your end.

Remi-Gau commented 7 months ago

jut released 0.10.4: testing in draft PR to see if your CI is happy