Closed jdkent closed 1 week ago
The PR modifies the initialization of the MKDAChi2 class by changing how the kernel_transformer parameter is handled. Instead of creating a default MKDAKernel instance with no arguments, it now passes the MKDAKernel class itself as the default value, allowing users to initialize it with custom arguments when needed.
classDiagram
class MKDAChi2 {
- kernel_transformer: MKDAKernel
+ kernel_transformer: Class<Kernel>
prior: float
memory: Memory
memory_level: int
}
class MKDAKernel {
}
class Memory {
location: None
verbose: int
}
MKDAChi2 --> MKDAKernel
MKDAChi2 --> Memory
note for MKDAChi2 "kernel_transformer is now a class reference, allowing custom initialization."
Change | Details | Files |
---|---|---|
Modified default parameter initialization in MKDAChi2 class constructor |
|
nimare/meta/cbma/mkda.py |
Issue | Objective | Addressed | Explanation |
---|---|---|---|
#906 | Fix the warning about MKDAKernel arguments being ignored due to premature initialization | ✅ |
Closes #906
Changes proposed in this pull request:
Summary by Sourcery
Bug Fixes: