search

neurosynth / ACE

Tools for automatic extraction of activation coordinates from published neuroimaging articles.
MIT License
42 stars 27 forks source link

Section parser for articles #2

Closed mbelmadani closed 8 years ago

tyarkoni commented 8 years ago

Hey, cool! Feel free to re-open this if you want me to merge it and I'll take a look.

mbelmadani commented 8 years ago

Hi there,

I will surely re-open it soon. I've only just finished my initial implementation so I was hoping to test it a bit more thoroughly before submitting it for review.

Let me know if you have any questions, or if you want me to re-open the pull request anyways.

Cheers

On Thu, Oct 15, 2015 at 12:34 PM, Tal Yarkoni notifications@github.com wrote:

Hey, cool! Feel free to re-open this if you want me to merge it and I'll take a look.

— Reply to this email directly or view it on GitHub https://github.com/neurosynth/ACE/pull/2#issuecomment-148498813.

tyarkoni commented 8 years ago

No worries, I'll just wait till you're ready. Thanks! On Oct 15, 2015 4:11 PM, "mbelmadani" notifications@github.com wrote:

Hi there,

I will surely re-open it soon. I've only just finished my initial implementation so I was hoping to test it a bit more thoroughly before submitting it for review.

Let me know if you have any questions, or if you want me to re-open the pull request anyways.

Cheers

On Thu, Oct 15, 2015 at 12:34 PM, Tal Yarkoni notifications@github.com wrote:

Hey, cool! Feel free to re-open this if you want me to merge it and I'll take a look.

— Reply to this email directly or view it on GitHub https://github.com/neurosynth/ACE/pull/2#issuecomment-148498813.

— Reply to this email directly or view it on GitHub https://github.com/neurosynth/ACE/pull/2#issuecomment-148522410.

tyarkoni commented 8 years ago

Oh, and let me know if you have questions about anything (though it looks like you have it pretty well figured out). I apologize for the poor (well, really nonexistent) state of the documentation. On Oct 15, 2015 4:11 PM, "mbelmadani" notifications@github.com wrote:

Hi there,

I will surely re-open it soon. I've only just finished my initial implementation so I was hoping to test it a bit more thoroughly before submitting it for review.

Let me know if you have any questions, or if you want me to re-open the pull request anyways.

Cheers

On Thu, Oct 15, 2015 at 12:34 PM, Tal Yarkoni notifications@github.com wrote:

Hey, cool! Feel free to re-open this if you want me to merge it and I'll take a look.

— Reply to this email directly or view it on GitHub https://github.com/neurosynth/ACE/pull/2#issuecomment-148498813.

— Reply to this email directly or view it on GitHub https://github.com/neurosynth/ACE/pull/2#issuecomment-148522410.

mbelmadani commented 8 years ago

Sounds good! I think I mostly just need to implement the feature for the remaining publisher platforms/Sources, and also have the feature configurable through the config file (I haven't looked at this part yet, but I'm thinking of something similar to the way parse_article works.) And of course, test it!

No need to apologize, the code, comments and examples were plenty to get me started. Thank you for open sourcing your work!

Cheers,

On Thu, Oct 15, 2015 at 3:36 PM, Tal Yarkoni notifications@github.com wrote:

Oh, and let me know if you have questions about anything (though it looks like you have it pretty well figured out). I apologize for the poor (well, really nonexistent) state of the documentation.

On Oct 15, 2015 4:11 PM, "mbelmadani" notifications@github.com wrote:

Hi there,

I will surely re-open it soon. I've only just finished my initial implementation so I was hoping to test it a bit more thoroughly before submitting it for review.

Let me know if you have any questions, or if you want me to re-open the pull request anyways.

Cheers

On Thu, Oct 15, 2015 at 12:34 PM, Tal Yarkoni notifications@github.com wrote:

Hey, cool! Feel free to re-open this if you want me to merge it and I'll take a look.

— Reply to this email directly or view it on GitHub https://github.com/neurosynth/ACE/pull/2#issuecomment-148498813.

— Reply to this email directly or view it on GitHub https://github.com/neurosynth/ACE/pull/2#issuecomment-148522410.

— Reply to this email directly or view it on GitHub https://github.com/neurosynth/ACE/pull/2#issuecomment-148542623.