search

neutralinojs / neutralino.js

JavaScript API for Neutralinojs
https://neutralino.js.org/docs/api/overview
MIT License
237 stars 47 forks source link

Removing circular dependency #101

Open Kanai2003 opened 7 months ago

Kanai2003 commented 7 months ago

Resolve: #88

there is a circular dependency between src/ws/websocket.ts and src/api/extensions.ts

Circular dependency: src/ws/websocket.ts -> src/api/extensions.ts -> src/ws/websocket.ts

removing dependency from websocket.ts

monsterkodi commented 7 months ago

hello kanai, your change fixes the first of the two mac build issues. the second error is still there when i build a fresh checkout of your branch:

`npm run build

@neutralinojs/lib@5.0.1 build node build.mjs

Preprocessing files... import src/index.ts generate dist/neutralino.mjs generate lib generate dist/neutralino.js /Users/kodi/Desktop/test/neutralino.js/node_modules/rollup-plugin-ts/dist/cjs/index.js:2082 isDefaultExport: specifier.name.text === "default", ^

TypeError: Cannot read properties of undefined (reading 'text') at getExportedSymbolFromExportSpecifier (/Users/kodi/Desktop/test/neutralino.js/node_modules/rollup-plugin-ts/dist/cjs/index.js:2082:41) at createExportSpecifierFromNameAndModifiers (/Users/kodi/Desktop/test/neutralino.js/node_modules/rollup-plugin-ts/dist/cjs/index.js:2103:29) at visitInterfaceDeclaration$5 (/Users/kodi/Desktop/test/neutralino.js/node_modules/rollup-plugin-ts/dist/cjs/index.js:2445:32) at visitNode$c (/Users/kodi/Desktop/test/neutralino.js/node_modules/rollup-plugin-ts/dist/cjs/index.js:2528:16) at /Users/kodi/Desktop/test/neutralino.js/node_modules/rollup-plugin-ts/dist/cjs/index.js:2554:13 at visitNodes (/Users/kodi/Desktop/test/neutralino.js/node_modules/typescript/lib/typescript.js:31214:30) at forEachChildInBlock (/Users/kodi/Desktop/test/neutralino.js/node_modules/typescript/lib/typescript.js:31921:16) at Object.forEachChild (/Users/kodi/Desktop/test/neutralino.js/node_modules/typescript/lib/typescript.js:31988:47) at Object.childContinuation (/Users/kodi/Desktop/test/neutralino.js/node_modules/rollup-plugin-ts/dist/cjs/index.js:2553:52) at visitModuleDeclaration$8 (/Users/kodi/Desktop/test/neutralino.js/node_modules/rollup-plugin-ts/dist/cjs/index.js:2455:28) { code: 'PLUGIN_ERROR', plugin: 'Typescript', hook: 'generateBundle' }`

monsterkodi commented 7 months ago

it might be a bug in rollup-plugin-ts , i am not sure.

Kanai2003 commented 7 months ago

Thanks @monsterkodi for addressing the second problem, let me figure it out

Kanai2003 commented 7 months ago

@monsterkodi you are right. It seems like need to update rollup library