search

neutralinojs / neutralinojs-cli

neu cli for Neutralinojs
https://neutralino.js.org/docs/cli/neu-cli
MIT License
93 stars 56 forks source link

Unzipper library corrupting files in Node.js v19.8.1 #200

Closed webwake closed 1 year ago

webwake commented 1 year ago

The unzipper library causes extracted files to get corrupt in the latest Node.js v19.8.1 on Windows 10 (worked with Node v18, have not tested other versions)

Also created an issue in unzipper, although library appears to be abandoned

May wish to switch to decompress library as that appears to be working

nicorac commented 1 year ago

Same issue here with Node 18:

Just created a pull request to replace unzipper with decompress which works correctly.

If anyone wants to test it, just install from my forked repo:

npm remove -g @neutralinojs/neu
npm install -g https://github.com/nicorac/neutralinojs-cli.git
shalithasuranga commented 1 year ago

Hey.. I am closing this one since the issue was fixed via #204 Thanks all :)