neu build does not replace previous builds

neutralinojs / neutralinojs-cli

neu cli for Neutralinojs

https://neutralino.js.org/docs/cli/neu-cli

MIT License

91 stars 56 forks source link

Closed hschneider closed 5 months ago

hschneider commented 8 months ago

When building via "neu build", the old binaries and release.neu are not replaced.

Expected behavior: All files should be replaced with the new builds.

Platform: Tested on macOS 14.1.1

CLI: Version 10.0.0

arckmr commented 8 months ago

hi @hschneider i want to work on this issue

hschneider commented 8 months ago

Thanks!

Sadaf-A commented 5 months ago

Hey @hschneider, I have previously contributed here. I have worked on this issue and come up with the following solution

I added a clearBuild() function in utils.js and utilized it in build.js to clear the previous build before bundling again

I have tested these changes locally using npm link

neubuild

shall i raise a PR for this?

hschneider commented 5 months ago

Absolutely!

Sadaf-A commented 5 months ago

Hey @hschneider , How does the PR look to you.

hschneider commented 5 months ago

Great work - but I'm not the maintainer :-) @shalithasuranga has to merge it.

Sadaf-A commented 5 months ago

Great work - but I'm not the maintainer :-) @shalithasuranga has to merge it.

I know but you're the author! does it solve the issue you were referring to or do i need to add anything

hschneider commented 5 months ago

As far as I can see it's perfect!