Fix waiting for frontendlib app port

neutralinojs / neutralinojs-cli

neu cli for Neutralinojs

https://neutralino.js.org/docs/cli/neu-cli

MIT License

91 stars 56 forks source link

Fix waiting for frontendlib app port #226

Closed simomat closed 8 months ago

simomat commented 8 months ago

Fix for #223 Tested locally with my app.

KTibow commented 7 months ago

This seems to have made it impossible for me to use the dev server. Even though port 5173 is being used, it just says "application will be launched when .. is ready" and eventually gives up.

*It works if I add --host to my vite server, which I don't want to do.

simomat commented 7 months ago

I can't see how this patch could be the reason, because it only removes the hard coded port. Seems more like 18a2fed doesn't work for you somehow. (You could check by using v10.0.0 which includes 18a2fed but not this patch.)

KTibow commented 7 months ago

@simomat ah nvm then, missed that. Regardless I sent in https://github.com/neutralinojs/neutralinojs-cli/pull/235 to fix this.