search

neutralinojs / neutralinojs-cli

neu cli for Neutralinojs
https://neutralino.js.org/docs/cli/neu-cli
MIT License
91 stars 56 forks source link

running neu update replaces neutralino.js #246

Closed Sadaf-A closed 4 months ago

Sadaf-A commented 5 months ago

Resolves: neutralinojs/neutralinojs-cli#247

shalithasuranga commented 4 months ago

Hello @Sadaf-A, I just tested the CLI and noticed it correctly updates the client with neu update. The following code snippet in downloader.js already copies it properly:

    fse.copySync(`.tmp/${constants.files.clientLibraryPrefix + getScriptExtension()}`
            , `./${clientLibrary}`);

Could you please double-check this solution? We can re-open this if there is an issue with neu update.

Thanks :tada:

Sadaf-A commented 4 months ago

Hello @Sadaf-A, I just tested the CLI and noticed it correctly updates the client with neu update. The following code snippet in downloader.js already copies it properly:

    fse.copySync(`.tmp/${constants.files.clientLibraryPrefix + getScriptExtension()}`
            , `./${clientLibrary}`);

Could you please double-check this solution? We can re-open this if there is an issue with neu update.

Thanks :tada:

Hey, my bad it seems to work fine I just checked and the file gets updated Thanks for the review!