search

neutralinojs / neutralinojs-cli

neu cli for Neutralinojs
https://neutralino.js.org/docs/cli/neu-cli
MIT License
94 stars 57 forks source link

`neu build` hangs up when run with bun #275

Closed CosmoMyzrailGorynych closed 3 months ago

CosmoMyzrailGorynych commented 3 months ago

Bun is a fast node.js alternative that is mostly compatible with its API. The "mostly" part results in archiver package not completing its zipping when run with bun, hanging forever. This prevents building neutralino apps if Bun is your node.js package runner, or if you use the neutralino-cli bundler programmatically through const {bundleApp} = require('@neutralinojs/neu/src/modules/bundler.js'); in a bun application. (Which is my case.)

изображение No messages appear after "Making app bundle ZIP file".

Now, I have zipping/unzipping capabilities in my Bun extension already, and I also faced problems with Archiver and used zip-lib instead. It's more modern, too.

I will probably make a PR with the replacement package for this issue, as its use case is exotic enough to not care about.

CosmoMyzrailGorynych commented 3 months ago

Confirmed that replacing archiver with zip-lib fixes the issue. Preparing a PR.