neutralinojs / neutralinojs.github.io

The official website and documentation of Neutralinojs
https://neutralino.js.org
MIT License
247 stars 133 forks source link

Docs for showOpenDialog and showSaveDialog #254

Closed SheetJSDev closed 1 year ago

SheetJSDev commented 2 years ago

First off, awesome work! We put together a small example of SheetJS + NeutralinoJS to read and write spreadsheet files.

There were a few minor nits in the documentation around showOpenDialog and showSaveDialog:

showOpenDialog

1) Options:

filter Filter[] ...

The actual code example uses filters.

2) Current code block:

let entries = await Neutralino.os.showOpenDialog('Save your diagram', {

The title probably should be "Open a diagram"

showSaveDialog

1) Current description:

Shows the file open dialog.

The description should be "Shows the file save dialog."

2) Options:

filter Filter[] ...

That probably should be filters

3) Current code block:

let entry = await Neutralino.os.showSaveDialog('Open a file', {

The title probably should be "Save to file"

ajay2827 commented 1 year ago

@SheetJSDev can I work on this issue, can you assign this to me

SheetJSDev commented 1 year ago

@ajay2827 feel free to send a PR

Aditya-A-G commented 1 year ago

@SheetJSDev