search

neutralinojs / neutralinojs.github.io

The official website and documentation of Neutralinojs
https://neutralino.js.org
MIT License
244 stars 122 forks source link

Update the committers list #278

Closed shalithasuranga closed 1 year ago

shalithasuranga commented 1 year ago

Add https://github.com/nicorac

8rxn commented 1 year ago

@shalithasuranga Can I work on this issue?

shalithasuranga commented 1 year ago

Sure, @8rxn, Thank you for your interest regarding this task :)

8rxn commented 1 year ago

@shalithasuranga Thanks for letting me work on this. I have raised a PR for the same.

nicorac commented 1 year ago

Thank you all for adding me 🎉

I have other PRs ready to be sent and one of them is an important change: it will allow a real single-file experience by embedding resources.neu file inside the binary (Windows .exe only, actually).

It's almost ready and works perfectly on my side but, before sending the PR, I'd like to share my thoughts with you (the devs) and users, to check if my implementation matches the expectations. Something like an RFC to define configuration field names, CLI support, ...

What's the best way to do this? Maybe an issue in neutralinojs repo?

nicorac commented 1 year ago

What's the best way to do this? Maybe an issue in neutralinojs repo?

Shall I open a new issue then?

shalithasuranga commented 1 year ago

Hey @8rxn, your PR was merged, thanks for sending it.

@nicorac Welcome and thanks for posting your idea. I think we already discussed creating a single binary by embedding the resource file somewhere in GitHub issues. Our conclusion was to use a separate resource file as right now due to the following benefits:

But, I would like to consider again about this idea since many developers suggested it again and again. So, I would like to suggest the following approach:

We'll keep the use of resources.neu as its, but we'll add another option to load resources via the binary itself. When the app starts, it checks the binary for resources. If found, it will load resources from there and set NL_RESMODE to executable. Otherwise, the usual resource-loading process happens. Also, we can introduce a new CLI option --res-loc=<bundle, directory, executable> and deprecate --load-dir-res. If this is doable as a cross-platform solution, I think we can include this in a major framework release.

Please let me know your thoughts :tada: