neutrinojs / neutrino

Create and build modern JavaScript projects with zero initial configuration.
https://neutrinojs.org
Mozilla Public License 2.0
3.95k stars 213 forks source link

Update dependency eslint-config-standard-jsx to v8 #1450

Closed renovate[bot] closed 5 years ago

renovate[bot] commented 5 years ago

This PR contains the following updates:

Package Type Update Change
eslint-config-standard-jsx dependencies major ^6.0.2 -> ^8.0.0

Release Notes

standard/eslint-config-standard-jsx ### [`v8.1.0`](https://togithub.com/standard/eslint-config-standard-jsx/compare/v8.0.1...v8.1.0) [Compare Source](https://togithub.com/standard/eslint-config-standard-jsx/compare/v8.0.1...v8.1.0) ### [`v8.0.1`](https://togithub.com/standard/eslint-config-standard-jsx/compare/v8.0.0...v8.0.1) [Compare Source](https://togithub.com/standard/eslint-config-standard-jsx/compare/v8.0.0...v8.0.1) ### [`v8.0.0`](https://togithub.com/standard/eslint-config-standard-jsx/compare/v7.0.0...v8.0.0) [Compare Source](https://togithub.com/standard/eslint-config-standard-jsx/compare/v7.0.0...v8.0.0) ### [`v7.0.0`](https://togithub.com/standard/eslint-config-standard-jsx/compare/v6.0.2...v7.0.0) [Compare Source](https://togithub.com/standard/eslint-config-standard-jsx/compare/v6.0.2...v7.0.0)

Renovate configuration

:date: Schedule: At any time (no schedule defined).

:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.

:recycle: Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".

:no_bell: Ignore: Close this PR and you won't be reminded about this update again.



This PR has been generated by Renovate Bot. View repository job log here.

edmorley commented 5 years ago

So I was wondering whether we should switch from using eslint-config-standard-jsx to eslint-config-standard-react instead, since the latter is a superset of the former? Or if we don't want to support React with this preset, perhaps we should instead remove eslint-config-standard-jsx?

I'd rather not have two standardjs Neutrino presets (since I personally think AirBnB is more popular / should be encouraged for those that don't otherwise have a preference), so I'm leaning towards the former (having this preset support React, even if that means those parts are unused for some users).

@neutrinojs/core-contributors thoughts?

timkelty commented 5 years ago

Going with eslint-config-standard-react sounds fine to me.