search

neutrinojs / neutrino

Create and build modern JavaScript projects with zero initial configuration.
https://neutrinojs.org
Mozilla Public License 2.0
3.95k stars 213 forks source link

Switch from eslint-loader to eslint-webpack-plugin #1637

Closed edmorley closed 8 months ago

edmorley commented 4 years ago

Recent Travis runs are showing:

npm WARN deprecated eslint-loader@4.0.2: This loader has been deprecated. Please use eslint-webpack-plugin

It appears that eslint-loader has been deprecated in favour of eslint-webpack-plugin: https://github.com/webpack-contrib/eslint-loader#warning-deprecated https://github.com/webpack-contrib/eslint-webpack-plugin

Sounds like we should switch in Neutrino 10.

constgen commented 4 years ago

I would assign this to myself with a pleasure.

Actually it doesn't require upgrading major version as there no actions from consumer side required. Am I right?

edmorley commented 4 years ago

Users could be passing custom options into the loader (via .neutrinorc.js customisation), and the new plugin supports different options. As such it's unfortunately a breaking change.

constgen commented 4 years ago

You convinced me