neutrinojs / neutrino

Create and build modern JavaScript projects with zero initial configuration.
https://neutrinojs.org
Mozilla Public License 2.0
3.95k stars 213 forks source link

Optional chaining doesn't work out of the box #1641

Closed linusdm closed 8 months ago

linusdm commented 4 years ago

Bug

linusdm commented 4 years ago

Adding the @babel/plugin-proposal-optional-chaining plugin to the babel configuration solves the issue. I'm not sure whether this is to be expected. I was assuming that since @babel/preset-env is enabled, and optional chaining has matured to stage four, explicitly adding a proposal plugin isn't required anymore.

const react = require("@neutrinojs/react");
const babelMerge = require("babel-merge");

module.exports = {
    options: {
        root: __dirname,
    },
    use: [
        react(),
        neutrino =>
            neutrino.config.module
                .rule("compile")
                .use("babel")
                .tap(options => babelMerge(options, {
                    plugins: ["@babel/plugin-proposal-optional-chaining"]
                }))
    ],
};
davidje13 commented 3 years ago

This is actually because Neutrino's default browser targets are all able to do optional chaining natively (https://github.com/neutrinojs/neutrino/blob/master/packages/web/index.js#L121)

That means the optional chaining never gets transpiled by Babel (which is good; the targets don't need it to be). But sadly, Webpack 4 fails to parse that syntax during the bundling stage. Apparently it's fixed in Webpack 5.

If you want to enable optional chaining transpilation without adding it explicitly, you can target a browser which needs the transpilation:

  use: [
    react({
      targets: { browsers: [
        // the default targets:
        'last 2 Chrome versions',
        'last 2 Firefox versions',
        'last 2 Edge versions',
        'last 2 Opera versions',
        'last 2 Safari versions',
        'last 2 iOS versions',
        // a target which needs optional chaining transpilation:
        'ie 11',
      ] }
    }),
  ],

But of course that's also just a workaround.

Further reading: