search

neutrinojs / neutrino

Create and build modern JavaScript projects with zero initial configuration.
https://neutrinojs.org
Mozilla Public License 2.0
3.95k stars 214 forks source link

Switch from Travis CI to GitHub Actions #1675

Closed Nic128 closed 2 years ago

Nic128 commented 2 years ago

Porting the changes over from https://github.com/neutrinojs/neutrino/pull/1663

Nic128 commented 2 years ago

Separate yamls with single job each, or single yaml with multiple jobs? Preference?

edmorley commented 2 years ago

Good question :-) I think I have a slight preference for one workflow file containing multiple jobs, since all the jobs are related (CI).

I'm not sure why the action still wasn't triggering - I cloned the PR branch and pushed to origin, and that's triggered it: https://github.com/neutrinojs/neutrino/actions

Perhaps now this repo has had at least one action run (ever), it might work for PRs?

Nic128 commented 2 years ago

I see now my PR actions appearing on the main repo. Thanks. I merged into one yaml, multiple jobs.

I have a problem with npm Verdaccio. It randomly fails/succeeds with installs with connection errors. yarn Verdaccio always passes.

Nic128 commented 2 years ago

The good news is, upgrading Verdaccio made it work. It also means we're dropping node 10.

We now need to remove travis as a required step.

juanpicado commented 2 years ago

I see now my PR actions appearing on the main repo. Thanks. I merged into one yaml, multiple jobs.

I have a problem with npm Verdaccio. It randomly fails/succeeds with installs with connection errors. yarn Verdaccio always passes.

You were using "verdaccio": "^4.10.0" should not fail like that due to the perf improvements were introduced in that version https://github.com/verdaccio/verdaccio/blob/4.x/CHANGELOG.md#features-2 anyway :) glad you have upgrade it ! 💯 if it persists ping me, I'd be glad to help make it more reliable.