neutrinojs / neutrino

Create and build modern JavaScript projects with zero initial configuration.
https://neutrinojs.org
Mozilla Public License 2.0
3.95k stars 214 forks source link

Support webpack-dev-server v4 #1700

Closed Archaeopteryx closed 6 months ago

Archaeopteryx commented 2 years ago

Bug or issue?

Please try to answer the following questions:

Webpack v4 migration guide

Modification necessary:

There are other files which also use these attributes.

edmorley commented 2 years ago

Hi!

This is expected, since Neutrino does not yet support webpack 5 (see #1624 and #1584).

The Neutrino docs say to use webpack-dev-server v3, eg: https://neutrinojs.org/packages/web/#requirements

And the packages have webpack-dev-server v3 in peerDependencies: https://github.com/neutrinojs/neutrino/blob/70822185e107b8e465a62b1eed74d6f62a559ed7/packages/web/package.json#L48

...so an error will be shown during npm/yarn install if a different version is used.

I would recommend adding yarn check (or whatever yarn v2+ / npm equivalent exists) to your CI pipeline, so unmet peer dependencies cause CI to fail, to make it clearer when incompatible versions are being used.

I'm going to close this out since everything is working as designed (wrt docs and declared dependencies), and the webpack 5 work is already being tracked in #1624. However, it's worth noting that I don't use this project any more, and unless someone else steps up to maintain it, it's unlikely that it will see many/any more releases.

edmorley commented 2 years ago

Actually, I see webpack-dev-server v4 supports webpack v4 too (and not only webpack v5), so the work to support webpack-dev-server v4 needn't be coupled with the webpack 5 work. As such, I've reopened this and changed the title to reflect it's for adding support.

edmorley commented 6 months ago

Closing since unfortunately this project is no longer maintained. See: https://github.com/neutrinojs/neutrino/issues/1707 https://github.com/neutrinojs/webpack-chain/issues/358