search

neutrinolabs / NeutrinoRDP

This is a fork of FreeRDP 1.0.1
Apache License 2.0
57 stars 75 forks source link

Implement support for gcc 5.x inline semantics #25

Closed matt335672 closed 3 years ago

matt335672 commented 3 years ago

gcc 5 (and later) default to -std=gnu11 rather than -std=gnu89. This chances the way that the inline keyword is handled by default [gnu.org]

This PR marks inline functions which are only used in their own translation units as static inline. Without this, the linker is unable to link the project executables, as the affected objects are marked as needing definitions from other translation units.

The change is still compatible with gcc 4 (used by RHEL 7 at the time of writing) and has been tested with gcc 10. It is nearly identical to upstream commit FreeRDP/FreeRDP@99492506d803a0f5a761e1efe935ee42115b04ba

metalefty commented 3 years ago

@jsorg71 Can you take a look at this?

jsorg71 commented 3 years ago

This looks good to me

metalefty commented 3 years ago

Can you merge? I have write permission only on xrdp related repositories but not on NeutrinoRDP.

metalefty commented 3 years ago

Otherwise, if you're happy with giving wite access, please give us it.