neutrinolabs / xorgxrdp

Xorg drivers for xrdp
Other
428 stars 108 forks source link

populate DRI2InfoRec driverNames #216

Closed akarl10 closed 2 years ago

akarl10 commented 2 years ago

https://github.com/neutrinolabs/xorgxrdp/issues/215

Currently needed for VDPAU with intel GPU Borrowed from xorg modesetting display driver

Nexarian commented 2 years ago

@jsorg71 What do you think?

jsorg71 commented 2 years ago

The coding style is a bit off but I think because modesetting does this, it right.

jsorg71 commented 2 years ago

I see the latest also includes crocus, although I'm not sure what that is.

        if (strcmp(driver_names[0], "i965") == 0 ||
            strcmp(driver_names[0], "iris") == 0 ||
            strcmp(driver_names[0], "crocus") == 0) {
            driver_names[1] = "va_gl";
        } else {
            driver_names[1] = driver_names[0];
        }
akarl10 commented 2 years ago

I see the latest also includes crocus, although I'm not sure what that is.

        if (strcmp(driver_names[0], "i965") == 0 ||
            strcmp(driver_names[0], "iris") == 0 ||
            strcmp(driver_names[0], "crocus") == 0) {
            driver_names[1] = "va_gl";
        } else {
            driver_names[1] = driver_names[0];
        }

You are right. Seems my source was not on the latest version. https://gitlab.freedesktop.org/xorg/xserver/-/commit/a7b0a7fabd137183cc42a5edb15697e354c4450c

I will include this change.

About the coding style: it is, as mentioned in the comment, a copy of modesetting's dri.c

Nexarian commented 2 years ago

@matt335672 @metalefty I'm OK with this change as it seems Jay is. As we integrate GFX it will definitely need to be updated, but this is a win for now.

matt335672 commented 2 years ago

@paravz @akarl10 - see also #219 which should prevent this in the future.

akarl10 commented 2 years ago

@paravz @akarl10 - see also #219 which should prevent this in the future.

👍 Makes definitely sense