Closed seflerZ closed 1 year ago
Thanks, CI is failing but that's fine. This PR depends on neutrinolabs/xrdp#2364.
@metalefty I've rebased the codes. Since the driver functions have been added. I deleted those hack codes at the same time.
BTW: Is there any tool or coding style guidance to pass the CI code style check?
Hi @seflerZ
coding standard is on the wiki.
Alternatively, there's a script run_astyle.sh in the xrdp/scripts directory that formats all your code for you using the astyle
utility.
I can see that this PR won't compile until neutrinolabs/xrdp#2364 is merged.
Hope that's useful.
@matt335672 Got it. I've fixed the code style issues in https://github.com/neutrinolabs/xrdp/pull/2364.
@metalefty - I'm unable to re-run the CI checks on this PR for some reason. Can you?
Re-ran CI jobs.
LGTM. @metalefty?
LGTM, too.
Thanks for code review. @metalefty & @matt335672
starting from which release version is this fix included in xrdp?
Close #150 @metalefty The xrdpMouse module doesn't handle touchpad inertial scrolling properly. At first I was intented to write a touchpad driver, now I found it uncessary. Because the RDP protocol doesn't have a touchpad channel, it should be good to add some touchpad function in the xrdpMouse driver.
Now the scrolling works great both on vertical and horizontal scrollings. Inertial scrolling also supported.![touchpad-scroll_Trim](https://user-images.githubusercontent.com/2093588/189598314-a9e4f21f-5572-436b-b47c-f2f84d5c41f4.gif)
Note: Some applications such as Firefox which uses WebKitGTK, have their own inertial handling process, so it won't work on every applications.