neutrinolabs / xorgxrdp

Xorg drivers for xrdp
Other
428 stars 108 forks source link

Don't delete RandR outputs and CRT controllers #283

Closed matt335672 closed 4 months ago

matt335672 commented 4 months ago

Draft for now until work resumes on devel.

This change doesn't delete outputs or CRT controllers when the screen configuration changes. Instead, the outputs are disconnected.

This emulates the behaviour of other virtual X servers (e.e. tigervnc) and prevents X applications from encountering BadRROutput or BadRRCtrc errors.

The following command can now be used to monitor RandR events generated by xorgxrdp. Previously it could fail with BadRROutput when reconnecting from a client with fewer screens.

xev -root -event randr [-display :xx]
metalefty commented 4 months ago

Is this related to https://github.com/neutrinolabs/xrdp/issues/2938?

matt335672 commented 4 months ago

I don't think it will be. It's more related to resize-on-reconnect.