neutronX / django-markdownx

Comprehensive Markdown plugin built for Django
https://neutronx.github.io/django-markdownx/
Other
854 stars 153 forks source link

Simple optimization inside views.py #243

Closed Nigel2392 closed 1 year ago

Nigel2392 commented 2 years ago

Instead of importing the markdownify function every time the view's POST method is called, instead import it at global scope.

Example:

markdownify_func = import_string(MARKDOWNX_MARKDOWNIFY_FUNCTION)

class MarkdownifyView(View):
    """
    Conversion of Markdown to HTML.
    """

    def post(self, request, *args, **kwargs):
        """
        Handling of the conversion from Markdown to HTML using the conversion
        function in settings under ``MARKDOWNX_MARKDOWNIFY_FUNCTION``.

        :param request: HTTP request.
        :param args: Default Django POST arguments.
        :param kwargs: Default Django POST keyword arguments.
        :return: HTTP response
        :rtype: django.http.HttpResponse
        """
        # Function used to be imported every POST request. 
        return HttpResponse(markdownify_func(request.POST['content']))
adi- commented 1 year ago

done. will be in next release.