search

neutronimaging / imagingsuite

Sources for imaging related tools
GNU General Public License v3.0
18 stars 9 forks source link

Recon exception reconstruction failure #681

Closed vlocateli closed 2 weeks ago

vlocateli commented 3 weeks ago

When running to reconstruct a FITS image file i get these errors: error

Instructions to reproduce: Get FITS image.

$ wget https://fits.gsfc.nasa.gov/samples/FOCx38i0101t_c0f.fits

Start the reconstruction.

When looking for the .so file in the directory of the error, the directory Framework doesn't exist, only frameworks followed by tomography sub-directory.

anderskaestner commented 3 weeks ago

@damskii9992, I think this is the same copying problem as with MacOS. Can you please update the post build copying for linux.

damskii9992 commented 3 weeks ago

@anderskaestner This appear to be a path-issue rather than the copying problem. The .so file that MuhRec is looking for is properly sitting in the lib folder of the application bundle, without the "1.0.0" suffix though. There are 3 c++ files with hard coded paths expecting a frameworks folder that shouldn't be there: "muhrecmainwindow.cpp", "modulelibnamemanger.cpp" and "tst_configbasetest.cpp" and in the modulelibnamemanger.cpp the code appends the 1.0.0 suffix to all library names . . .

damskii9992 commented 3 weeks ago

A fix might be as simple as replacing the: fullName = fullName+"Frameworks/lib"+name+".so.1.0.0"; on line 86 of modulelibnamemanger.cpp with: fullName = fullName+"lib/lib"+name+".so";

damskii9992 commented 3 weeks ago

By the way, thank you for testing out the build @vlocateli :) Issues like this only shows when you actually use the app, so it is greatly appreciated

vlocateli commented 2 weeks ago

I managed to fix it, now it reconstruct the FITS image. I created a branch named issue681_reconstructionfail. Could @anderskaestner or @damskii9992 create this branch so I can push? Thanks. proof :)

damskii9992 commented 2 weeks ago

I have now created a branch with this name. Feel free to push your changes to it and open a pull request :)

vlocateli commented 2 weeks ago

perm_denied I don't have enough permission do push to this branch. :(

damskii9992 commented 2 weeks ago

@anderskaestner seems like you need to change some settings regarding access rights.

anderskaestner commented 2 weeks ago

Ok, I check

A

On 13 Jun 2024, at 14:08, Christian Dam Vedel @.***> wrote:

@anderskaestnerhttps://github.com/anderskaestner seems like you need to change some settings regarding access rights.

— Reply to this email directly, view it on GitHubhttps://github.com/neutronimaging/imagingsuite/issues/681#issuecomment-2165470636, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACVIDXGR4V5OXULXM3KYEKDZHGDTLAVCNFSM6AAAAABJFNYNT6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRVGQ3TANRTGY. You are receiving this because you were mentioned.Message ID: @.***>

anderskaestner commented 2 weeks ago

You are now invited to the repository. Then, you should be able to push your changes. Please, only push to branches and do pull requests to merge with the main branch.