Remove OpenMP from code

vlocateli commented 1 week ago

Remove OpenMP from code and use C++11 thread instead, because of MSVC OpenMP support. This is a great undertaking that should be split into several issues:

Each changed function shall have a unit test
Possibly also a benchmark test to confirm speedup
Also application testing is needed in particular for processing modules

Low-hanging

[ ] ./core/kipl/kipl/include/math/sums.h
[ ] ./core/kipl/kipl/src/math/sums.cpp
[ ] ./core/kipl/kipl/include/segmentation/thresholds.h (omp is not really used)
[ ] ./core/kipl/kipl/src/base/core/histogram.cpp (omp is probably only legacy, thread pool implementation exists)
[ ] ./core/algorithms/pyimgalg/pyPolynomialCorrection.cpp (only includes the omp.h, otherwise nothing)
[ ] ./core/kipl/kipl/include/math/core/image_statistics.hpp
[ ] ./frameworks/tomography/Preprocessing/StdPreprocModules/src/SpotClean2.cpp (only includes the omp.h, otherwise nothing)

Do-able

[ ] ./core/algorithms/ImagingAlgorithms/src/PolynomialCorrection.cpp (some restructuring may be needed for efficient use of thread pool)
[ ] ./frameworks/tomography/Preprocessing/StdPreprocModules/src/SpotClean.cpp (threading should be implemented in the algorithm-class)
[ ] ./core/kipl/kipl/include/filters/core/medianfilter.hpp

Requires planning

[ ] ./frameworks/tomography/Preprocessing/StdPreprocModules/src/ISSfilter.cpp
[ ] ./frameworks/tomography/Backprojectors/StdBackProjectors/src/MultiProjBPparallel.cpp
[ ] ./core/algorithms/AdvancedFilters/ISSfilter.hpp
[ ] ./core/algorithms/AdvancedFilters/ISSfilterQ3Dp.hpp
[ ] ./core/algorithms/AdvancedFilters/ISSfilterQ3D.hpp
[ ] ./core/kipl/kipl/include/base/core/timage.hpp
[ ] ./core/algorithms/ImagingAlgorithms/src/SpotClean.cpp
[ ] ./frameworks/tomography/Preprocessing/StdPreprocModules/src/WaveletRingClean.cpp (already has std::thread implementation, but threading should be moved to algorithm-class.)
[ ] ./core/kipl/kipl/include/segmentation/core/kernelfuzzykmeans.hpp (algorithm must be fixed first)
[ ] ./core/kipl/kipl/include/segmentation/core/fuzzykmeans.hpp (algorithm must be fixed first)

KipTool stuff

This source moved to a different repository and should be removed, there is already an issue about this.

[ ] ./applications/kiptool/src/main.cpp
[ ] ./frameworks/imageprocessing/modules/StatisticsModules/src/DistanceStatistics.cpp
[ ] ./frameworks/imageprocessing/modules/StatisticsModules/src/ImageHistogram.cpp
[ ] ./frameworks/imageprocessing/modules/AdvancedFilterModules/src/ISSfilterModule.cpp
[ ] ./frameworks/imageprocessing/modules/AdvancedFilterModules/src/NonLinDiffusion.cpp
[ ] ./frameworks/imageprocessing/modules/PorespaceModules/src/PoreSizeMapModule.cpp
[ ] ./frameworks/imageprocessing/modules/ImagingModules/src/stripefiltermodule.cpp
[ ] ./frameworks/imageprocessing/modules/BaseModules/src/DoseCorrection.cpp
[ ] ./frameworks/imageprocessing/modules/BaseModules/src/ScaleData.cpp
[ ] ./frameworks/imageprocessing/modules/BaseModules/src/ClampData.cpp
[ ] ./frameworks/imageprocessing/modules/BaseModules/src/VolumeProject.cpp
[ ] ./frameworks/imageprocessing/modules/ClassificationModules/src/FuzzyCMeans.cpp
[ ] ./frameworks/imageprocessing/modules/ClassificationModules/src/BasicThreshold.cpp
[ ] ./frameworks/imageprocessing/modules/ClassificationModules/src/KernelFuzzyCMeans.cpp
[ ] ./frameworks/imageprocessing/modules/PCAModules/src/PCAFilterModule.cpp

Not analyzed list of files

anderskaestner commented 1 week ago

Please wait with this one. I want to analyze the situation and make a strategy.

vlocateli commented 1 week ago

@anderskaestner Ok, got it. Also, I sent you an e-mail. I don't know if you received it.

anderskaestner commented 1 week ago

I checked the code now. There is a lot to do, and I suggest taking it in small steps. It is currently not the highest priority.

vlocateli commented 1 week ago

@anderskaestner, I'll do the low-hanging ones and do-able ones. If I can do more, I'll comment here.

neutronimaging / imagingsuite