neutrons / PyRS

Reduction and visualization software for Stress Residual (HB2B)
https://neutrons-pyrs.readthedocs.io/en/latest/index.html
GNU General Public License v3.0
6 stars 7 forks source link

JOSS: Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)? #781

Closed andyfaff closed 2 years ago

andyfaff commented 2 years ago

The modules covered in the API documentation (on readthedocs) are satisfactory. However, there are many other functions/objects that are not documented clearly. With Python there is an expectation that objects/functions not prefixed by _ are public. I would presume this JOSS guideline is asking that those public functions be documented clearly. Take, for example, pyrs.core.instrument_geometry.HidraSetup, this class requires a detector_setup parameter for instantiation, but it's not specified what that parameter is (float/int/object/etc).

fanchercm commented 2 years ago

Additional modules were included in the readthedocs to better cover the key functions and classes in the pyrs API