search

neutrons / addie

ADvanced DIffraction Environment - GUI for Reduction of Neturon Time-of-Flight Total Scattering Diffraction Data
GNU General Public License v3.0
7 stars 4 forks source link

Merge GSAS option from right click error #80

Open marshallmcdonnell opened 7 years ago

marshallmcdonnell commented 7 years ago

When I right-click a workspace in Bragg Peak Tab and select Merge GSAS, I get the following error:

Traceback (most recent call last):
  File "/SNS/users/j35/git/FastGR_dev/fastgr/treelib.py", line 306, in do_merge_to_gss
    self._mainWindow.get_workflow.write_gss_file(ws_name_list=bank_ws_list, gss_file_name=new_gss_file_name)
AttributeError: 'function' object has no attribute 'write_gss_file'
marshallmcdonnell commented 7 years ago

@wdzhou has this fixed in a pull request. Just need to fix other issues and then can merge.

marshallmcdonnell commented 7 years ago

Now, for 6cf9d22fbc07e82840b294c4812d7a9763c78b92 I get the following

Traceback (most recent call last):
  File "/SNS/users/ntm/software/fastgr/FastGR/build/lib/addie/treelib.py", line 306, in do_merge_to_gss
    self._mainWindow.get_workflow.write_gss_file(ws_name_list=bank_ws_list, gss_file_name=new_gss_file_name)
AttributeError: 'function' object has no attribute 'write_gss_file'
marshallmcdonnell commented 6 years ago

For fd6a2c5bb2d55a4b132c7fb35bcd874d212bde63, I was able to right-click but when I got to save, I get the following:

Traceback (most recent call last):
  File "/SNS/users/ntm/software/fastgr/FastGR/build/lib/addie/treelib.py", line 306, in do_merge_to_gss
    self._mainWindow.get_workflow().write_gss_file(ws_name_list=bank_ws_list, gss_file_name=new_gss_file_name)
  File "/SNS/users/ntm/software/fastgr/FastGR/build/lib/addie/addiedriver.py", line 578, in write_gss_file
    Format='SLOG', Bank=1, Append=append_mode)
  File "/opt/mantidnightly/bin/mantid/simpleapi.py", line 1050, in algorithm_wrapper
    set_properties(algm, *args, **final_keywords)
  File "/opt/mantidnightly/bin/mantid/simpleapi.py", line 994, in set_properties
    do_set_property(key, value)
  File "/opt/mantidnightly/bin/mantid/simpleapi.py", line 986, in do_set_property
    alg_object.setProperty(key, new_value)
ValueError: Invalid value for property InputWorkspace (MatrixWorkspace) "NOM94736tof_bank1": The workspace must have units of TOF
marshallmcdonnell commented 5 years ago

For master commit 4b7c29e, get the following error when trying to save the test file GSAS_NaNO3_275C.gsa:

SaveGSS-[Notice] SaveGSS started
SaveGSS-[Error] SaveGSS: Failed to open file. Error was: No such file or directory in "('/home/ntm/tests/('/home/ntm/tests/GSAS_NaNO3_275C.gsa', 'GSAS File (*.gsa)')"
SaveGSS-[Error] Error in execution of algorithm SaveGSS:
SaveGSS-[Error] SaveGSS: error (see log)
Traceback (most recent call last):
  File "/home/ntm/direnv/python3/addie/build/lib/addie/treelib.py", line 310, in do_merge_to_gss
    self._mainWindow.get_workflow().write_gss_file(ws_name_list=bank_ws_list, gss_file_name=new_gss_file_name)
  File "/home/ntm/direnv/python3/addie/build/lib/addie/addiedriver.py", line 582, in write_gss_file
    Format='SLOG', Bank=1, Append=append_mode)
  File "/home/ntm/software/mantid/build-master/bin/mantid/simpleapi.py", line 1112, in algorithm_wrapper
    algm.execute()
RuntimeError: SaveGSS: error (see log)

Looks like there is a tuple on the SaveGSS-[Error] SaveGSS: Failed to open file. Error was: No such file or directory in "('/home/ntm/tests/('/home/ntm/tests/GSAS_NaNO3_275C.gsa', 'GSAS File (*.gsa)')" line instead of the filename only.