search

neutrons / multiphonon

multiphonon (getDOS)
MIT License
2 stars 5 forks source link

Test coverage #77

Closed bjmorgan closed 6 years ago

bjmorgan commented 6 years ago

https://github.com/openjournals/joss-reviews/issues/440

Excellent to see this project using continuous integration, and reporting code coverage. Is there a reason why the tests do not cover a good proportion of the code (~25%)?

yxqd commented 6 years ago

Thanks, @bjmorgan. One module that is not yet tested at all contains some helper functions for plotting: https://coveralls.io/builds/14390180/source?filename=multiphonon%2Fbackward%2Fplotutils.py. But I agree some modules deserve more coverage and I will work on them.

yxqd commented 6 years ago

Hi @bjmorgan, test coverage was improved by #81 to 88%. Please check. Thanks.

bjmorgan commented 6 years ago

88% is a lot healthier.