search

neutrons / multiphonon

multiphonon (getDOS)
MIT License
3 stars 5 forks source link

JOSS author list #78

Closed bjmorgan closed 6 years ago

bjmorgan commented 6 years ago

https://github.com/openjournals/joss-reviews/issues/440

I am looking at the JOSS review criterion:

Authorship: Has the submitting author (@yxqd) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?

It seems unusual that people have contributed enough to be named in the first paragraph of the README, but not be included as authors on the JOSS paper. I wanted to check that this is deliberate?

yxqd commented 6 years ago

Thank you @bjmorgan for your comments. The original multiphonon code was written more than 10 years ago by Max (the 2nd author of this JOSS paper) when he was writing his PhD thesis and several other authors made some improvements to it later on, fixing some annoyances. That code has shown some age and there are multiple versions with tweaks by various contributors, making it hard for users to choose which version to use. Besides, each version has its own problems. The new code is a response to the renewed interests in treating the powder INS data in a consistent, reproducible manner, and to the requirements gathered from users/contributors-of-the-original-code (see the original whiteboard and the github issue). We then decide that it is time to start from scratch and implement a new code. The code in this repository is therefore a complete rewrite and the only code that resembles the previous code is in the forward.phonon module, previously authored by Max. That being said, we are certainly grateful for explorations by and fruitful discussions with other contributors and they are acknowledged in the paper.