search

neuviemeporte / mzretools

Tools for reversing DOS games, primarily inspection of MZ executables
GNU General Public License v2.0
33 stars 2 forks source link

Failing tests #1

Closed lethal-guitar closed 7 months ago

lethal-guitar commented 8 months ago

I've just built the current master branch, and noticed that some tests are failing:

[  FAILED  ] 4 tests, listed below:
[  FAILED  ] Dos.MzHeader
[  FAILED  ] AnalysisTest.FindRoutines
[  FAILED  ] AnalysisTest.FindFarRoutines
[  FAILED  ] AnalysisTest.CodeCompare

Is this to be expected, or am I missing something?

neuviemeporte commented 8 months ago

Hi Nikolai, thanks for letting me know. No, it was not supposed to fail, but was failing because it could not find the path for the sample Hello World MZ application used in the test. I made a symlink to it in my environment a long time ago and did not bother to check if a freshly cloned repo builds in a long time.

I pushed out a commit changing the path in the tests to address the parent directory as a quick-and-dirty fix.

lethal-guitar commented 8 months ago

Ah I see, makes sense. 👍🏻

Maybe you've already considered it, but just in case you haven't, CMake's configure_file command to copy the file into the build directory could also be an option.