search

nevat / abbayedesmorts-gpl

l'Abbaye des Morts - ported to Linux, Pandora, GCW0, Wii and PSP
GNU General Public License v3.0
73 stars 16 forks source link

Graphics glitches with images that are constructed from several tiles #20

Closed th-otto closed 2 weeks ago

th-otto commented 2 weeks ago

In the SDL2 version, some graphics that are constructed have one line of background between the upper and lower part, like the bell:

sdl2

The older SDL 1.2 version does not have this problem:

sdl12

carstene1ns commented 2 weeks ago

These are scaling artifacts. If you disable linear scaling in main.c line 47, these are not present.

th-otto commented 2 weeks ago

Ok, but why is it then enabled by default?

vanfanel commented 2 weeks ago

Ok, but why is it then enabled by default?

Bilinear scaling looks way better than nearest, unless you pair nearest with integer scaling. Also, bilinear is similar to what analog TV used to show, while nearest is pure digital perfection that doesn't look well on pixel art based games. Ideally, what this game needs is a CRT simulation shader, which VKBasalt gives me on GNU/Linux without need of any code on the game itself.

carstene1ns commented 2 weeks ago

I have worked around this in the new version.